Simplify and optimize the command response future/promise flow #1517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The command response flow uses a futures that piggies back to the query result builder and then completes the overall result promise. Only the terminal node needs to be a promise/future as we are always on the same connection context. The internal command response flow can uses instead a Completable flow that is much more straightforward for debugging and saves un-necessary method calls. Changes: Use a Completable response flow internally instead of the Promise based flow.
vietj
force-pushed
the
simplify-internal-promise-flow
branch
from
2d26e23 to
5a383f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The command response flow uses a futures that piggies back to the query result builder and then completes the overall result promise.
Only the terminal node needs to be a promise/future as we are always on the same connection context.
The internal command response flow can uses instead a
Completableflow that is much more straightforward for debugging and saves un-necessary method calls.Changes:
Use a
Completableresponse flow internally instead of thePromisebased flow.